Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Handle ENOTCONN on read() over TCP #8030

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@rgacogne
Copy link
Member

commented Jul 5, 2019

Short description

When a non-blocking connect() has returned EINPROGRESS, it looks like BSD can return ENOTCONN on read() even after a write() succeeded.
We did not get a trace confirming that read() can indeed return ENOTCONN in that case yet, though.

Fixes #8021.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
dnsdist: Handle ENOTCONN on read() over TCP
When a non-blocking connect() has returned `EINPROGRESS`, it looks
like BSD can return `ENOTCONN` on `read()` even after a `write()`
succeeded.

@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Jul 5, 2019

@rgacogne

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

Confirmed on FreeBSD via a PoC, see #8021 (comment). After reading the source code of NetBSD and OpenBSD I believe we can get ENOTCONN on the first sendmsg() if the handshake has not been completed yet. Based on #7685 it looks like we actually experienced that on MacOS as well.

@rgacogne rgacogne merged commit 91287ec into PowerDNS:master Aug 9, 2019

23 of 26 checks passed

LGTM analysis: C/C++ Analysis failed (could not build the base commit (1353ea2))
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
ci/circleci: build-auth Your tests passed on CircleCI!
Details
ci/circleci: build-auth-docs Your tests passed on CircleCI!
Details
ci/circleci: build-dnsdist Your tests passed on CircleCI!
Details
ci/circleci: build-dnsdist-docs Your tests passed on CircleCI!
Details
ci/circleci: build-recursor Your tests passed on CircleCI!
Details
ci/circleci: build-recursor-docs Your tests passed on CircleCI!
Details
ci/circleci: test-auth-algorithms Your tests passed on CircleCI!
Details
ci/circleci: test-auth-api Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-bind Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-gmysql Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-gpgsql Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-gsqlite3 Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-ldap Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-lmdb Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-mydns Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-odbc-mssql Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-odbc-sqlite3 Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-tinydns Your tests passed on CircleCI!
Details
ci/circleci: test-dnsdist-regression Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-api Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-bulk Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-regression Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:ddist-tcp-enotconn-read-bsd branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.