Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Catch exceptions thrown when handling a TCP response #8078

Merged
merged 2 commits into from Jul 16, 2019

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Jul 15, 2019

Short description

We need to handle it gracefully if a function called from handleResponse() throws, most likely because the answer received from the backend was not valid.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
We need to handle it gracefully if a function called from
handleResponse() throws, most likely because the answer received
from the backend was not valid.
@rgacogne rgacogne merged commit a8ee0d7 into PowerDNS:master Jul 16, 2019
27 checks passed
Loading
@rgacogne rgacogne deleted the ddist-tcp-answer-exception branch Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant