Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Fix unlimited retries when TCP Fast Open is enabled #8079

Merged
merged 2 commits into from Jul 16, 2019

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Jul 15, 2019

Short description

Using the same flag to indicate whether a connection was reused after being pulled from the pool AND to know if the TFO flag should be passed to sendmsg() led to an unlimited number of reconnection
attempts when TFO was enabled and the backend closed the connection right after a write (sendmsg() succeeds then read() returns 0 right away).

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
rgacogne added 2 commits Jul 15, 2019
Using the same flag to indicate whether a connection was reused
after being pulled from the pool AND to know if the TFO flag should
be passed to sendmsg() led to an unlimited number of reconnection
attemps when TFO was enabled and the backend closed the connection
right after a write (sendmsg() succeeds then read() returns 0 right
away).
@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Jul 15, 2019
@rgacogne rgacogne merged commit cd59f26 into PowerDNS:master Jul 16, 2019
27 checks passed
Loading
@rgacogne rgacogne deleted the ddist-tcp-fastopen-retries branch Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant