Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m4/systemd.m4: Fail when systemctl is not available #8081

Merged

Conversation

@pieterlexis
Copy link
Member

@pieterlexis pieterlexis commented Jul 15, 2019

Short description

We use systemctl to determine the version as to find out what features
to enable in the unit file.

Thanks to @zeha for mentioning this

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@zeha
Copy link
Collaborator

@zeha zeha commented Jul 15, 2019

failure from circleci:

configure: error: conditional "HAVE_SYSTEMD_DYNAMIC_USER" was never defined.

We use systemctl to determine the version as to find out what features
to enable in the unit file.
@pieterlexis pieterlexis force-pushed the configure-fail-on-no-systemctl branch from aea207c to 1f98840 Jul 16, 2019
@Habbie
Copy link
Member

@Habbie Habbie commented Jul 17, 2019

CircleCI: configure: error: systemctl not found

@pieterlexis
Copy link
Member Author

@pieterlexis pieterlexis commented Jul 17, 2019

CircleCI: configure: error: systemctl not found

Hmm, are we building with systemd support there?

@Habbie
Copy link
Member

@Habbie Habbie commented Jul 17, 2019

Hmm, are we building with systemd support there?

We install libsystemd but not systemd; some builds have --disable-systemd but most don't.

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Jul 17, 2019

We install libsystemd but not systemd; some builds have --disable-systemd but most don't.

Shall we enable systemd there, since I guess most of our users will run under systemd nowadays?

@pieterlexis
Copy link
Member Author

@pieterlexis pieterlexis commented Jul 17, 2019

Shall we enable systemd there, since I guess most of our users will run under systemd nowadays?

I just did the exact opposite, mostly because we don't test the systemd functionality at all.

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Jul 17, 2019

But that means that we won't build the code paths specific to systemd on our CI, right? While if we enabled it, we could at least see compilation errors even if we don't test anything else?

@pieterlexis
Copy link
Member Author

@pieterlexis pieterlexis commented Jul 17, 2019

makes sense, fixing

@pieterlexis pieterlexis force-pushed the configure-fail-on-no-systemctl branch from 8453d56 to 0e0e64f Jul 17, 2019
@pieterlexis pieterlexis merged commit c928207 into PowerDNS:master Jul 22, 2019
27 checks passed
@pieterlexis pieterlexis deleted the configure-fail-on-no-systemctl branch Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants