Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errno review #8083

Merged
merged 10 commits into from Sep 18, 2019

Conversation

@omoerbeek
Copy link
Member

commented Jul 16, 2019

Short description

Goes some way to address #7845
Most obvious cases fixed, although there remain some. Also, consequently uses stringerror() instead of variations of string(strerror(errno))

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@omoerbeek omoerbeek force-pushed the omoerbeek:errno-review branch from 0185673 to 16f0c28 Jul 16, 2019
pdns/pdns_recursor.cc Outdated Show resolved Hide resolved
pdns/pdns_recursor.cc Outdated Show resolved Hide resolved
pdns/dnsdist-tcp.cc Outdated Show resolved Hide resolved
close(pipefds[0]);
close(pipefds[1]);
errlog("Error setting the TCP thread communication pipe non-blocking: %s", strerror(errno));
errlog("Error setting the TCP thread communication pipe non-blocking: %s", strerror(err));

This comment has been minimized.

Copy link
@chbruyand

chbruyand Aug 5, 2019

Member
Suggested change
errlog("Error setting the TCP thread communication pipe non-blocking: %s", strerror(err));
errlog("Error setting the TCP thread communication pipe non-blocking: %s", stringerror(err));
pdns/nameserver.cc Outdated Show resolved Hide resolved
pdns/syncres.cc Show resolved Hide resolved
pdns/tcpreceiver.cc Outdated Show resolved Hide resolved
@omoerbeek

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

Fixed mentioned cases.

@omoerbeek omoerbeek requested a review from chbruyand Sep 2, 2019
@omoerbeek omoerbeek merged commit 2e7f677 into PowerDNS:master Sep 18, 2019
26 of 28 checks passed
26 of 28 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
ci/circleci: build-auth Your tests passed on CircleCI!
Details
ci/circleci: build-auth-docs Your tests passed on CircleCI!
Details
ci/circleci: build-dnsdist Your tests passed on CircleCI!
Details
ci/circleci: build-dnsdist-docs Your tests passed on CircleCI!
Details
ci/circleci: build-recursor Your tests passed on CircleCI!
Details
ci/circleci: build-recursor-docs Your tests passed on CircleCI!
Details
ci/circleci: checkout Your tests passed on CircleCI!
Details
ci/circleci: test-auth-algorithms Your tests passed on CircleCI!
Details
ci/circleci: test-auth-api Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-bind Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-gmysql Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-gpgsql Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-gsqlite3 Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-ldap Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-lmdb Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-mydns Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-odbc-mssql Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-odbc-sqlite3 Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-tinydns Your tests passed on CircleCI!
Details
ci/circleci: test-dnsdist-regression Your tests passed on CircleCI!
Details
ci/circleci: test-ixfrdist-regression Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-api Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-bulk Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-regression Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@omoerbeek omoerbeek deleted the omoerbeek:errno-review branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.