Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errno review #8083

Merged
merged 10 commits into from Sep 18, 2019
Merged

Errno review #8083

merged 10 commits into from Sep 18, 2019

Conversation

@omoerbeek
Copy link
Member

@omoerbeek omoerbeek commented Jul 16, 2019

Short description

Goes some way to address #7845
Most obvious cases fixed, although there remain some. Also, consequently uses stringerror() instead of variations of string(strerror(errno))

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
pdns/pdns_recursor.cc Outdated Show resolved Hide resolved
pdns/pdns_recursor.cc Outdated Show resolved Hide resolved
pdns/dnsdist-tcp.cc Outdated Show resolved Hide resolved
close(pipefds[0]);
close(pipefds[1]);
errlog("Error setting the TCP thread communication pipe non-blocking: %s", strerror(errno));
errlog("Error setting the TCP thread communication pipe non-blocking: %s", strerror(err));
Copy link
Member

@chbruyand chbruyand Aug 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
errlog("Error setting the TCP thread communication pipe non-blocking: %s", strerror(err));
errlog("Error setting the TCP thread communication pipe non-blocking: %s", stringerror(err));

pdns/nameserver.cc Outdated Show resolved Hide resolved
pdns/syncres.cc Show resolved Hide resolved
pdns/tcpreceiver.cc Outdated Show resolved Hide resolved
@omoerbeek
Copy link
Member Author

@omoerbeek omoerbeek commented Aug 12, 2019

Fixed mentioned cases.

@omoerbeek omoerbeek requested a review from chbruyand Sep 2, 2019
@omoerbeek omoerbeek merged commit 2e7f677 into PowerDNS:master Sep 18, 2019
28 checks passed
@omoerbeek omoerbeek deleted the errno-review branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants