Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Prevent a dangling DOHUnit pointer when send() failed #8112

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Jul 22, 2019

Short description

In the quite unlikely case where sending a DoH query toward the backend over the UDP socket failed, we could have left a dangling pointer to the DOHUnit struct, possibly leading to a crash when the IDState was cleaned up later.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Jul 22, 2019
@rgacogne rgacogne merged commit c719137 into PowerDNS:master Jul 22, 2019
22 checks passed
Loading
@rgacogne rgacogne deleted the dnsdist-doh-dangling-send-error branch Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant