Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add Lua bindings, rules and action for DoH #8153

Merged
merged 8 commits into from Aug 7, 2019

Conversation

@rgacogne
Copy link
Member

commented Aug 2, 2019

Short description

This PR adds:

  • HTTPPathRegexRule to be able to match the path of a DoH query with a regular expression ;
  • HTTPStatusAction to be able to return a specific HTTP response to a DoH query ;
  • Lua bindings (DNQuestion:getHTTPHeaders(), DNSQuestion:getHTTPHost(), DNSQuestion:getHTTPPath(), DNSQuestion:getHTTPQueryString() and DNSQuestion:getHTTPScheme()` to be able to inspect a DoH query from Lua ;
  • DNSQuestion:setHTTPResponse() to be able to return a specific HTTP response from Lua as well.

Fixes #8133.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Aug 2, 2019

@rgacogne rgacogne changed the title Ddist doh http more dnsdist: Add Lua bindings, rules and action for DoH Aug 2, 2019

@rgacogne

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

Travis failures are unrelated (network issues, apparently).

rgacogne added some commits Aug 1, 2019

@rgacogne rgacogne force-pushed the rgacogne:ddist-doh-http-more branch from 2719fee to 1ddac02 Aug 5, 2019

@rgacogne

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

Rebased to fix a conflict in dnsdist-lua-actions.cc.

@chbruyand
Copy link
Member

left a comment

LGTM!

Show resolved Hide resolved pdns/dnsdist-lua-bindings-dnsquestion.cc Outdated

@rgacogne rgacogne merged commit 016a165 into PowerDNS:master Aug 7, 2019

24 of 27 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
ci/circleci: test-dnsdist-regression CircleCI is running your tests
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: build-auth Your tests passed on CircleCI!
Details
ci/circleci: build-auth-docs Your tests passed on CircleCI!
Details
ci/circleci: build-dnsdist Your tests passed on CircleCI!
Details
ci/circleci: build-dnsdist-docs Your tests passed on CircleCI!
Details
ci/circleci: build-recursor Your tests passed on CircleCI!
Details
ci/circleci: build-recursor-docs Your tests passed on CircleCI!
Details
ci/circleci: test-auth-algorithms Your tests passed on CircleCI!
Details
ci/circleci: test-auth-api Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-bind Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-gmysql Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-gpgsql Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-gsqlite3 Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-ldap Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-lmdb Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-mydns Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-odbc-mssql Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-odbc-sqlite3 Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-tinydns Your tests passed on CircleCI!
Details
ci/circleci: test-ixfrdist-regression Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-api Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-bulk Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-regression Your tests passed on CircleCI!
Details

@rgacogne rgacogne deleted the rgacogne:ddist-doh-http-more branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.