Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add SetNegativeAndSOAAction() and its Lua binding #8171

Merged
merged 3 commits into from Feb 7, 2020

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Aug 7, 2019

Short description

Fixes #4747 by making it possible to add a SOA record in the additional section on a NXDomain or NoData answer.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@rgacogne
Copy link
Member Author

@rgacogne rgacogne commented Nov 22, 2019

Rebased to fix a conflict. Note that this new action should probably get the ability to set some flags in the generated response, as implemented for existing actions in #8556.

@rgacogne rgacogne force-pushed the dnsdist-soa-in-negative branch from 6b25cd5 to ba57212 Compare Feb 7, 2020
@rgacogne
Copy link
Member Author

@rgacogne rgacogne commented Feb 7, 2020

Rebased to fix a conflict, added the ability to set some flags in the generated response in the meantime.

@rgacogne rgacogne merged commit 008cf88 into PowerDNS:master Feb 7, 2020
28 checks passed
@rgacogne rgacogne deleted the dnsdist-soa-in-negative branch Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant