-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnsdist: Add support for early DoH HTTP responses #8206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, I'm just wondering if matching shouldn't be also done on HTTP method ?
I'm also wondering if we may want to send the possibly set custom headers in the response ?
It might be a request at some point, yes, but for now I'm trying to keep it simple. |
I'd really like dnsdist not to become a full-fledged HTTP server :-) |
I know, this is just that you may expect to get the custom headers you set via |
Oh, you are right! I'm not 100% sure it's a good idea to apply these to "early" responses, but I guess it might be something that users will expect.. |
Yes, really depends on your custom headers usage. But I think you would expect it in use cases like #7900 |
I'm worried about the case where one does not want the |
Fixed the default |
5167a1c
to
9b2ef60
Compare
Rebased to fix a conflict. |
Short description
The
HTTPPathRule
andHTTPPathRegexRule
, and theLua
bindings to access the HTTP informations are only invoked for valid DNS over HTTP queries. This PR adds support for responding to HTTP queries before the DNS payload has been parsed, thus allowing to respond to all HTTP queries.Checklist
I have: