Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add minTLSVersion for DoH and DoH #8207

Merged
merged 3 commits into from Aug 27, 2019

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Aug 16, 2019

Short description

Fixes #8202.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
Copy link
Contributor

@franklouwers franklouwers left a comment

Does the remark about gnuTLS apply to addDOHLocal() as well? If so, best to document it. I can't directly where the default is being set. I assume there's no minimum (well, I hope we're not trying to do sslv2/sslv3)?

Loading

pdns/dnsdistdist/docs/reference/config.rst Outdated Show resolved Hide resolved
Loading
@rgacogne
Copy link
Member Author

@rgacogne rgacogne commented Aug 16, 2019

Does the remark about gnuTLS apply to addDOHLocal() as well? If so, best to document it.

It does not, DoH only uses OpensSL.

I can't directly where the default is being set. I assume there's no minimum (well, I hope we're not trying to do sslv2/sslv3)?

The default is TLS 1.0+, I'll document that.

Loading

@rgacogne rgacogne requested a review from chbruyand Aug 27, 2019
@rgacogne rgacogne merged commit 6147573 into PowerDNS:master Aug 27, 2019
27 checks passed
Loading
@rgacogne rgacogne deleted the dnsdist-tls-version branch Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants