Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Implement TLS Session Ticket Keys management for DoH #8349

Merged
merged 4 commits into from
Sep 29, 2019
Merged

dnsdist: Implement TLS Session Ticket Keys management for DoH #8349

merged 4 commits into from
Sep 29, 2019

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Sep 26, 2019 •
edited
Loading

Short description

Still needs regression tests (in progress).

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Sep 26, 2019
@rgacogne
Copy link
Member Author

We should make sure that dnsdist still compiles without libssl after these changes, I realize I didn't test that!

chbruyand
chbruyand approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@chbruyand chbruyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just a tiny nit if you are about to push other changes. Otherwise great :)

FYI it compiles with --without-libssl (and thus without DoH support).

pdns/doh.hh Show resolved Hide resolved
pdns/doh.hh
@@ -82,6 +93,7 @@ struct DOHFrontend
HTTPVersionStats d_http1Stats;
HTTPVersionStats d_http2Stats;


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove if any other modification in this file.

@rgacogne rgacogne merged commit ef9ed3b into PowerDNS:master Sep 29, 2019
@rgacogne rgacogne deleted the ddist-doh-tickets branch September 29, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chbruyand chbruyand chbruyand approved these changes

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rgacogne @chbruyand