Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Lowercase custom DoH header names #8365

Merged
merged 2 commits into from
Oct 2, 2019
Merged

dnsdist: Lowercase custom DoH header names #8365

merged 2 commits into from
Oct 2, 2019

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Oct 1, 2019

Short description

Fixes #8353.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Oct 1, 2019
@rgacogne
Copy link
Member Author

rgacogne commented Oct 1, 2019

This should also be done for newDOHResponseMapEntry().

@rgacogne
Copy link
Member Author

rgacogne commented Oct 2, 2019

This should also be done for newDOHResponseMapEntry().

Done.

@rgacogne rgacogne merged commit ecec499 into PowerDNS:master Oct 2, 2019
@rgacogne rgacogne deleted the ddist-lowercase-custom-header-names branch October 2, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omoerbeek omoerbeek omoerbeek approved these changes

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.4.0
Development

Successfully merging this pull request may close these issues.

[dnsdist] Custom response headers must be in lower case
2 participants
@rgacogne @omoerbeek