Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: More prometheus fixes #8368

Merged
merged 5 commits into from
Oct 2, 2019

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Oct 2, 2019

Short description

  • Add per-frontend and per-server response counters
  • Fix handling of latency-sum and latency-count in prometheus (found via promtool check metrics)
  • Fix a typo in 'tcpdownstreamtimeouts' prometheus description (found via promtool check metrics)
  • Add missing prometheus descriptions for dnsdist_pool_servers and dnsdist_pool_active_servers (found via promtool check metrics)
  • Deduplicate DoH frontend names in prometheus

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Oct 2, 2019
@rgacogne rgacogne merged commit 5b5eeb4 into PowerDNS:master Oct 2, 2019
@rgacogne rgacogne deleted the ddist-prometheus-third branch October 2, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant