Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Fix the caching of large entries #8408

Merged
merged 5 commits into from
Oct 15, 2019

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Oct 11, 2019

Short description

It turns out that the packet cache suffered a regression since 1.3.0: the buffer allocated to incoming queries, and used to store the cached response if any, was not big enough to allow large (>1500 bytes for UDP, > 512 bytes for TCP/DoT/DoH) answers to be retrieved. We can now always retrieve entries up to 4096 bytes.
We also cached entries larger than what we could actually retrieve, we now no longer cache entries larger than 4096 bytes.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne
Copy link
Member Author

Rebased to fix a conflict.

@rgacogne rgacogne merged commit 746c7c6 into PowerDNS:master Oct 15, 2019
@rgacogne rgacogne deleted the ddist-buffer-size-cache branch October 15, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants