Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Implement ref counting for the DOHUnit object #8416

Merged
merged 1 commit into from Oct 23, 2019

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Oct 14, 2019

Short description

It turns out that, at least when testing with ASAN enabled, we sometimes trigger use-after-free detection because we get the response from the backend, send it to the client then delete the
object before the send() call to the backend even returned.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

It turns out that, at least when testing with ASAN enabled, we
sometimes trigger use-after-free detection because we get the
response from the backend, send it to the client then delete the
object before the send() call to the backend even returned.
@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Oct 14, 2019
@rgacogne rgacogne requested a review from chbruyand Oct 21, 2019
@rgacogne rgacogne merged commit 94aaa1c into PowerDNS:master Oct 23, 2019
28 checks passed
@rgacogne rgacogne deleted the ddist-dohunit-refcount branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant