Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -WShadow warnings #8440

Merged
merged 13 commits into from Nov 11, 2019
Merged

Fix -WShadow warnings #8440

merged 13 commits into from Nov 11, 2019

Conversation

cmouse
Copy link
Contributor

@cmouse cmouse commented Oct 19, 2019

Short description

Fix lots of shadowing variables

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

pdns/opensslsigners.cc Outdated Show resolved Hide resolved
@cmouse cmouse force-pushed the shadow branch 4 times, most recently from eb8c8c7 to 97c0ee3 Compare Oct 25, 2019
Copy link
Member

@rgacogne rgacogne left a comment

Looks good, thanks! I'm just worried about this PR making us call std::bitset::count() in the condition of a for-loop.

pdns/nsecrecords.cc Outdated Show resolved Hide resolved
pdns/nsecrecords.cc Outdated Show resolved Hide resolved
cmouse added 13 commits Oct 29, 2019
json.hh:39:42: warning: declaration of ‘what’ shadows a member of 'this' [-Wshadow]
nsecrecords.cc:79:12: warning: declaration of ‘count’ shadows a member of 'this' [-Wshadow]
nsecrecords.cc:141:12: warning: declaration of ‘count’ shadows a member of 'this' [-Wshadow]
e.g.
opensslsigners.cc:761:10: warning: declaration of ‘hash’ shadows a member of 'this' [-Wshadow]
It should be msg not hash
odbxprivate.cc:190:138: warning: declaration of 'list' shadows a member of 'this'
smysql.cc:458:13: warning: declaration of 'reconnect' shadows a member of 'this'
coprocess.cc:161:40: warning: declaration of 'receive' shadows a member of 'this'
iputils.hh:785:32: warning: declaration of 'parent' shadows a global declaration
dnsdist.hh:668:147: warning: declaration of 'isTCP' shadows a member of 'this'
rfc2136handler.cc:616:30: warning: declaration of 'forwardPacket' shadows a member of 'this'
rfc2136handler.cc:616:30: warning: declaration of 'forwardPacket' shadows a member of 'this'
webserver.hh:128:36: warning: declaration of 'what' shadows a member of 'this'
speedtest.cc:603:25: warning: declaration of 'rr' shadows a previous local
@pieterlexis pieterlexis merged commit 19f3ec6 into PowerDNS:master Nov 11, 2019
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants