Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add support dumping TLS keys via keyLogFile #8442

Merged
merged 2 commits into from Oct 23, 2019

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Oct 21, 2019

Short description

This PR:

  • moves the DoH ticket keys logic into the DOHAcceptContext object, with the OCSP responses and SSL context objects ;
  • adds support dumping TLS keys via the new keyLogFile directive.

The new keyLogFile feature is similar to what various programs do when the SSLKEYLOGFILE environment variable is set, and uses the format described in:

https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/Key_Log_Format

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

rgacogne added 2 commits Oct 23, 2019
@rgacogne rgacogne force-pushed the ddist-ssl-key-log-file branch from 5c063eb to 7f8a5a3 Compare Oct 23, 2019
@rgacogne rgacogne merged commit 574bad3 into PowerDNS:master Oct 23, 2019
27 checks passed
@rgacogne rgacogne deleted the ddist-ssl-key-log-file branch Oct 23, 2019
rgacogne added a commit to rgacogne/pdns that referenced this issue Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant