Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add metrics about TLS handshake failures for DoH and DoT #8447

Merged
merged 2 commits into from Oct 23, 2019

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Oct 22, 2019

Short description

So we can detect an abnormal rate of TLS connections failing because the cipher suite or the protocols supported are too restrictive, for example.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne
Copy link
Member Author

@rgacogne rgacogne commented Oct 22, 2019

Doesn't compile on Travis because SSL_R_VERSION_TOO_LOW is not defined there, I'll investigate later.

@rgacogne rgacogne force-pushed the ddist-tls-error-counters branch from 4bc7073 to 3a449f5 Compare Oct 22, 2019
@rgacogne
Copy link
Member Author

@rgacogne rgacogne commented Oct 22, 2019

Doesn't compile on Travis because SSL_R_VERSION_TOO_LOW is not defined there, I'll investigate later.

Fixed.

@rgacogne rgacogne force-pushed the ddist-tls-error-counters branch from 3a449f5 to f34fdcc Compare Oct 22, 2019
@rgacogne rgacogne merged commit ca00884 into PowerDNS:master Oct 23, 2019
28 checks passed
@rgacogne rgacogne deleted the ddist-tls-error-counters branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant