dnsdist: Implement LuaFFIRule, LuaFFIAction and LuaFFIResponseAction #8505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also spotted some remaining debug messages in the code :-) |
|
This pull request introduces 1 alert when merging 4eea956 into 930ed0c - view on LGTM.com new alerts:
|
rgacogne
force-pushed
the
dnsdist-lua-ffi
branch
from
d4f7597
to
cacc770
Compare
rgacogne
force-pushed
the
dnsdist-lua-ffi
branch
from
0129700
to
075f948
Compare
|
Rebased to fix conflicts. |
Using a sorted vector provides a much faster lookup time than a std::set when the number of points on the circle (weight of the backend) is huge. A boost::flat_set is almost as fast as a sorted vector but the insertion time is quite bad.
rgacogne
force-pushed
the
dnsdist-lua-ffi
branch
from
075f948
to
8eb84a5
Compare
chbruyand
approved these changes
Feb 13, 2020
| @@ -172,6 +174,29 @@ void setupLuaBindings(bool client) | |||
|
|
|||
| /* ComboAddress */ | |||
| g_lua.writeFunction("newCA", [](const std::string& name) { return ComboAddress(name); }); | |||
| g_lua.writeFunction("newCAFromRaw", [](const std::string& raw, boost::optional<uint16_t> port) { | |||
There was a problem hiding this comment.
Maybe document the new functions introduced here ?
There was a problem hiding this comment.
This function is very specific to what we do with our own Lua FFI code, I'll ponder if it's worth documenting it.
|
Thanks a lot for the review! |
…erface.h Reported by LGTM.
rgacogne
force-pushed
the
dnsdist-lua-ffi
branch
from
80364a8
to
c0e86fc
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR implements:
LuaFFIRule: to be able to write a query/response selector inLuausing the FFI interface ;LuaFFIAction: to be able to write actions inLuausing the FFI interface ;LuaFFIResponseAction: to be able to write response actions inLuausing the FFI interface ;LuaRule(): to be able to write a query/response selector inLua(non-FFI version) ;setServerPolicyLuaFFI: to be able to write server load-balancing policies inLuausing the FFI interface.It also refactor the code around the server selection policies and backends, slightly speeding up some of the built-in C++ policies in the process, and adding unit tests for them.
Closes #7617.
Checklist
I have: