Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Lowercase the name blocked by a SMT dynamic block #8524

Merged
merged 1 commit into from Nov 15, 2019

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Nov 12, 2019

Short description

This does not change the existing behavior since we are doing a case-insensitive comparison but it's nicer when generating metrics about the dynamic block rules.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

This does not change the existing behavior since we are doing a
case-insensitive comparison but it's nicer when generating metrics
about the dynamic block rules.
@rgacogne rgacogne added this to the dnsdist-1.4.x milestone Nov 12, 2019
@rgacogne rgacogne removed this from the dnsdist-1.4.x milestone Nov 12, 2019
@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Nov 12, 2019
@rgacogne rgacogne merged commit 3c42d38 into PowerDNS:master Nov 15, 2019
26 checks passed
@rgacogne rgacogne deleted the ddist-lowercase-dynblocksmt branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant