Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the source and destination ports to the protobuf msg #8702

Merged
merged 3 commits into from Jan 15, 2020

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Jan 14, 2020

Short description

  • for all protobuf messages in dnsdist ;
  • for incoming queries / outgoing responses in the recursor.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Member

@omoerbeek omoerbeek left a comment

Looks good. If I see things correctly, protobuf receivers using the old definition will not be hindered by this, right?
If so, I like to include this in rec-4.3.0-beta2

@rgacogne
Copy link
Member Author

rgacogne commented Jan 15, 2020

Looks good. If I see things correctly, protobuf receivers using the old definition will not be hindered by this, right?

They will just ignore the new fields, yes.

If so, I like to include this in rec-4.3.0-beta2

Fine by me! :-)

@rgacogne rgacogne merged commit ec51242 into PowerDNS:master Jan 15, 2020
25 checks passed
@rgacogne rgacogne deleted the ddist-protobuf-ports branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants