Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add getTag()/setTag() Lua bindings for a DNSResponse #8782

Merged
merged 1 commit into from Feb 7, 2020

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Feb 5, 2020

Short description

LuaWrapper doesn't support inheritance, so even though DNSResponse inherits from the DNSQuestion object the bindings are not inherited.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

LuaWrapper doesn't support inheritance, so even though DNSResponse
inherits from the DNSQuestion object the bindings are not inherited.
@rgacogne rgacogne added this to the dnsdist-1.4.x milestone Feb 5, 2020
@rgacogne rgacogne merged commit a7213aa into PowerDNS:master Feb 7, 2020
26 checks passed
@rgacogne rgacogne deleted the ddist-tag-response branch Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant