Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'queue full' metrics for our remote logger, log at debug only #8883

Merged
merged 1 commit into from Mar 3, 2020
Merged

Add 'queue full' metrics for our remote logger, log at debug only #8883

merged 1 commit into from Mar 3, 2020
+25 −16

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Mar 2, 2020

Short description

Fixes #8629.
Note that the metrics are accessible from the RemoteLogger object in dnsdist but not in the recursor. It's still an improvement to stop flooding the logs!

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne requested a review from omoerbeek Mar 2, 2020
@rgacogne rgacogne merged commit bf14cf4 into PowerDNS:master Mar 3, 2020
28 checks passed
@rgacogne rgacogne deleted the remote-logger-full branch Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omoerbeek omoerbeek

Assignees
No one assigned
Labels
defect dnsdist rec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dnsdist: Metric for "FrameStreamLogger: queue full, dropping."
2 participants
@rgacogne @omoerbeek