Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of reconnections in Remote Logger (dnsdist, rec) #8887

Merged

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Mar 3, 2020

Short description

  • Do not lock while trying to reconnect ;
  • Try to reconnect right away if the disconnection was detected in the maintenance thread ;
  • Keep queueing messages when the connection has been lost, until the buffer gets full.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Member

@omoerbeek omoerbeek left a comment

Looks good, very small nits.

pdns/remote_logger.cc Show resolved Hide resolved
pdns/remote_logger.cc Show resolved Hide resolved
rgacogne added 2 commits Mar 6, 2020
- Do not lock while trying to reconnect ;
- Try to reconnect right away if the disconnection was detected in
  the maintenance thread ;
- Keep queueing messages when the connection has been lost, until
  the buffer gets full.
Also remove the now unused d_maxQueuedBytes field.
@rgacogne rgacogne force-pushed the remote-logger-keep-queueing-reconnect branch from c606bd2 to 745889e Compare Mar 6, 2020
@rgacogne
Copy link
Member Author

@rgacogne rgacogne commented Mar 6, 2020

Rebased!

@rgacogne rgacogne merged commit e10c8f6 into PowerDNS:master Mar 9, 2020
29 checks passed
@rgacogne rgacogne deleted the remote-logger-keep-queueing-reconnect branch Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants