Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect {Libre,Open}SSL functions availability during configure #8900

Merged
merged 1 commit into from Mar 9, 2020

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Mar 5, 2020

Short description

Instead of using version numbers, which is brittle, notably because LibreSSL faked the OpenSSL version numbers at some point without implementing all the newly introduced functions.

Fixes #8739.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Instead of using version numbers, which is brittle, notably because
LibreSSL faked the OpenSSL version numbers at some point without
implementing all the newly introduced functions.
@rgacogne rgacogne force-pushed the openssl-libssl-detection branch from dcea663 to 629440d Compare Mar 5, 2020
@rgacogne
Copy link
Member Author

@rgacogne rgacogne commented Mar 9, 2020

@omoerbeek This is low priority but, if you don't mind, I would really appreciate it if you could check that this doesn't break anything on OpenBSD :-)

@omoerbeek omoerbeek self-requested a review Mar 9, 2020
@omoerbeek
Copy link
Member

@omoerbeek omoerbeek commented Mar 9, 2020

auth, dnsdist and rec configure and build show no surprises.

@rgacogne rgacogne merged commit de29634 into PowerDNS:master Mar 9, 2020
29 checks passed
@rgacogne rgacogne deleted the openssl-libssl-detection branch Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants