Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Gracefully handle a failure to remove FD on (re)-connection #9057

Merged
merged 1 commit into from Apr 28, 2020

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Apr 24, 2020

Short description

When more than one socket per backend is used, we might not have added all the socket descriptors to the multiplexer and that's fine.

The error is harmless except for an error message and a leaked file descriptor (which is not an issue unless new servers are added in a loop and fail).

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

When more than one socket per backend is used, we might not have
added all the socket descriptors to the multiplexer and that's fine.
@rgacogne rgacogne added this to the dnsdist-1.5.0 milestone Apr 24, 2020
@rgacogne rgacogne merged commit 665d7cc into PowerDNS:master Apr 28, 2020
29 checks passed
@rgacogne rgacogne deleted the ddist-socket-removal branch Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant