dnsdist: Implement an ACL in the internal web server #9229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we end up with an empty ACL (everything will be refused) if the new one is not valid.
chbruyand
reviewed
Jun 17, 2020
| @@ -0,0 +1,22 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
Maybe add the license header ?
There was a problem hiding this comment.
Didn't we stop adding it? I'm a bit lost on that topic to be fair :-)
| @@ -9,6 +9,13 @@ To visually interact with dnsdist, try add :func:`webserver` to the configuratio | |||
|
|
|||
| Now point your browser at http://127.0.0.1:8083 and log in with any username, and that password. Enjoy! | |||
|
|
|||
| Since 1.5.0, only connections from 127.0.0.1 and ::1 are allowed by default. To allow connections from 192.0.2.1, instead: | |||
There was a problem hiding this comment.
This is actually a list of netmasks. So this would probably be better to document here and after that it accepts various forms (eg. 192.0.2.1, 192.0.0.0/16, and even !192.0.0.0/16)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Implement the same kind of ACL for the internal web server that we have in the auth and rec, and restricts to 127.0.0.1 and ::1 by default.
Checklist
I have: