Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Prevent a copy of a pool's backends when selecting a server #9360

Merged
merged 1 commit into from Jul 29, 2020

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Jul 29, 2020

Short description

It makes a noticeable difference as soon as the number of backends in a pool increases to more than 8 backends, and a huge difference when there is a large number of backends.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Member

@omoerbeek omoerbeek left a comment

This reads good (I checked the const usage in particular) and fits what we have seen.

@omoerbeek
Copy link
Member

omoerbeek commented Jul 29, 2020

The regress failures a bit worrying, though

@rgacogne
Copy link
Member Author

rgacogne commented Jul 29, 2020

The regress failures a bit worrying, though

Both failures seemed unrelated and the tests passed after a restart.

@rgacogne rgacogne merged commit 3fe6910 into PowerDNS:master Jul 29, 2020
29 checks passed
@rgacogne rgacogne deleted the ddist-prevent-backends-copy branch Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants