Tostring #9361
Merged
Tostring #9361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we should remove the existing |
|
possibly, yes. I can restore them if the tests pass. |
|
Travis CI failure is due to missing python3 |
zeha
reviewed
Aug 19, 2020
cmouse
force-pushed
the
tostring
branch
2 times, most recently
from
b8fd4ed
to
e5f412e
Compare
Fixed. |
rgacogne
approved these changes
Aug 20, 2020
|
Nice! Can you resolve the conflicts so that we can merge this? |
|
could you rebase again? (sorry) |
1 similar comment
|
could you rebase again? (sorry) |
LuaWrapper supports __tostring for objects to make str() work.
|
done. |
rgacogne
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Short description
Bind __tostring instead of toString for Lua. This way stringification works automatically.
Checklist
I have: