Skip to content

Tostring #9361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2021
Merged

Tostring #9361

merged 3 commits into from
Feb 24, 2021

Conversation

cmouse
Copy link
Contributor

@cmouse cmouse commented Jul 29, 2020

Short description

Bind __tostring instead of toString for Lua. This way stringification works automatically.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne
Copy link
Member

I don't think we should remove the existing toString binding, otherwise we will break existing code/configurations.

@cmouse
Copy link
Contributor Author

cmouse commented Jul 29, 2020

possibly, yes. I can restore them if the tests pass.

@cmouse
Copy link
Contributor Author

cmouse commented Aug 19, 2020

Travis CI failure is due to missing python3

@cmouse cmouse force-pushed the tostring branch 2 times, most recently from b8fd4ed to e5f412e Compare August 20, 2020 06:17
@cmouse
Copy link
Contributor Author

cmouse commented Aug 20, 2020

I don't think we should remove the existing toString binding, otherwise we will break existing code/configurations.

Fixed.

@Habbie
Copy link
Member

Habbie commented Sep 14, 2020

Nice! Can you resolve the conflicts so that we can merge this?

@pieterlexis
Copy link
Contributor

could you rebase again? (sorry)

1 similar comment
@pieterlexis
Copy link
Contributor

could you rebase again? (sorry)

@cmouse
Copy link
Contributor Author

cmouse commented Feb 24, 2021

done.

@rgacogne rgacogne added this to the dnsdist-1.6.0 milestone Feb 24, 2021
@rgacogne rgacogne merged commit b472d9c into PowerDNS:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants