Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Handle EINTR in DelayPipe #9381

Merged
merged 1 commit into from Aug 24, 2020
Merged

dnsdist: Handle EINTR in DelayPipe #9381

merged 1 commit into from Aug 24, 2020

Conversation

rgacogne
Copy link
Member

Short description

Otherwise the DelayPipe thread might stop because the read() operation has been interrupted by a signal (like SIGWINCH, which is quite annoying).
Also remove the unused read() operation.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne
dnsdist: Handle EINTR in DelayPipe
f58cb6a 
Otherwise the DelayPipe thread might stop because the read() operation
has been interrupted by a signal (like SIGWINCH, which is quite annoying).
Also remove the unused `read()` operation.
@rgacogne rgacogne added this to the dnsdist-1.6.0 milestone Aug 12, 2020
@omoerbeek omoerbeek self-requested a review August 24, 2020 06:33
omoerbeek
omoerbeek approved these changes Aug 24, 2020
View reviewed changes
pdns/delaypipe.cc Show resolved Hide resolved
@rgacogne rgacogne merged commit fe4e65f into PowerDNS:master Aug 24, 2020
@rgacogne rgacogne deleted the ddist-delaypipe-eintr branch August 24, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omoerbeek omoerbeek omoerbeek approved these changes

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rgacogne @omoerbeek