Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Speed up the round robin policy #9382

Merged
merged 2 commits into from Aug 24, 2020
Merged

dnsdist: Speed up the round robin policy #9382

merged 2 commits into from Aug 24, 2020

Conversation

rgacogne
Copy link
Member

Short description

Working with indices instead of copying shared pointers results in a nice speed up, cutting the CPU time in half.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.6.0 milestone Aug 11, 2020
@omoerbeek omoerbeek self-requested a review August 24, 2020 06:33
omoerbeek
omoerbeek reviewed Aug 24, 2020
View reviewed changes
Copy link
Member

@omoerbeek omoerbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm extending the tests to see if my comments make sense

pdns/dnsdistdist/dnsdist-lbpolicies.cc Show resolved Hide resolved
pdns/dnsdistdist/dnsdist-lbpolicies.cc Show resolved Hide resolved
rgacogne and others added 2 commits August 24, 2020 10:03
@rgacogne
dnsdist: Speed up the round robin policy
6de0f45 
Working with indices instead of copying shared pointers results in
a nice speed up, cutting the CPU time in half.
@rgacogne @omoerbeek
dnsdist: Handle an empty servers list in the RR policy
6b30cce 
Co-authored-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
@rgacogne
Copy link
Member Author

Rebased to fix a failing commit.

@rgacogne rgacogne merged commit fe96aea into PowerDNS:master Aug 24, 2020
@rgacogne rgacogne deleted the ddist-speedup-rr branch August 24, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omoerbeek omoerbeek omoerbeek approved these changes

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rgacogne @omoerbeek