Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary allocations and copies with DNSName::toDNSString() #9424

Merged
merged 2 commits into from Aug 31, 2020

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Aug 31, 2020

Short description

It should provide a small speed-up for KVS lookups, SpoofAction, LogAction and fixup case handling in dnsdist. It might save a few allocations for DNSSEC validation in the rec, and perhaps in some cases in the LMDB backend as well.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

pdns/misc.hh Outdated Show resolved Hide resolved
Co-authored-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
@rgacogne rgacogne merged commit df4b690 into PowerDNS:master Aug 31, 2020
@rgacogne rgacogne deleted the to-dnsstring-copy branch August 31, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants