dnsdist-1.5.x: Fix getEDNSOptions() for {AN,NS}COUNT != 0 and ARCOUNT = 0 #9542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 1.5.0, calling getEDNSOptions() from Lua would result in a ServFail for queries that had no records in additional but at least one record in either the answer or authority section, such as a NOTIFY, because of a bug in parseEDNSOptions(). That last function incorrectly called slowParseEDNSOptions() in that case, triggering an exception to be raised because slowParseEDNSOptions() does not expect to be called for a packet with no record in the additional section. parseEDNSOptions() now returns `false` for packets that have no record in the additional section. (cherry picked from commit 38af359)
rgacogne
force-pushed
the
ddist15-fix-parse-edns-options
branch
from
e2f2465 to
f3392de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Backport of #9513 to dnsdist-1.5.x.
Since 1.5.0, calling
getEDNSOptions()from Lua would result in aServFailfor queries that had no records in additional but at least one record in either the answer or authority section, such as aNOTIFY, because of a bug inparseEDNSOptions(). That last function incorrectly calledslowParseEDNSOptions()in that case, triggering an exception to be raised becauseslowParseEDNSOptions()does not expect to be called for a packet with no record in the additional section.parseEDNSOptions()now returnsfalsefor packets that have no record in the additional section.(cherry picked from commit 38af359)
Checklist
I have: