Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Fix eBPF filtering of long qnames #9689

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Nov 9, 2020

Short description

This commit switches to the use of eBPF positive offsets to access the content of the transport and application layers, since using negative offsets (needed to access the other layers) led to issues with long qnames.
This is cleaner anyway :-)

Fixes #9626.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

This commit switches to the use of eBPF positive offsets to access
the content of the transport and application layers, since using
negative offsets (needed to access the other layers) led to issues
with long qnames.
This is cleaner anyway :-)
@rgacogne rgacogne added this to the dnsdist-1.6.0 milestone Nov 9, 2020
@rgacogne rgacogne merged commit 47ec4eb into PowerDNS:master Nov 10, 2020
@rgacogne rgacogne deleted the ddist-fix-ebpf-long-names branch November 10, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnsdist ebpf dropping names longer than 72 chars
1 participant