Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist-1.5.x: Fix eBPF filtering of long qnames #9717

Merged
merged 1 commit into from Nov 13, 2020
Merged

dnsdist-1.5.x: Fix eBPF filtering of long qnames #9717

merged 1 commit into from Nov 13, 2020

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Nov 13, 2020 •
edited

Short description

This commit switches to the use of eBPF positive offsets to access the content of the transport and application layers, since using negative offsets (needed to access the other layers) led to issues with long qnames.
This is cleaner anyway :-)

Backport of #9689 to rel/dnsdist-1.5.x.

(cherry picked from commit abbc728)

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@rgacogne
dnsdist: Fix eBPF filtering of long qnames
759309e 
This commit switches to the use of eBPF positive offsets to access
the content of the transport and application layers, since using
negative offsets (needed to access the other layers) led to issues
with long qnames.
This is cleaner anyway :-)

(cherry picked from commit abbc728)
@rgacogne rgacogne added this to the dnsdist-1.5.x milestone Nov 13, 2020
@rgacogne rgacogne merged commit e73a8c1 into PowerDNS:rel/dnsdist-1.5.x Nov 13, 2020
@rgacogne rgacogne deleted the ddist15-fix-ebpf-long-names branch November 13, 2020 11:23
@rgacogne rgacogne mentioned this pull request Mar 10, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.5.x
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rgacogne