/ pdns Public
dnsdist: Add per connection queries count and duration stats for DoH #9738
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
This is done by implementing a per-thread table of DoH connections, keyed on the underlying file descriptor, since we don't have access to the
h2o_conn_tobject but only to the
h2o_socket_twhen the connection is first established (
h2o_socket_read_start()callback) or terminated (
on_closecallback of the socket).
This also makes it possible to use a
std::shared_ptrinstead of our custom reference counting, since we keep an entry in the table for the duration of the connection and don't need to rely on h2o's raw pointer anymore to pass our data.