Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: add ability to set ACL from a file #9822

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

qvr
Copy link
Contributor

@qvr qvr commented Dec 7, 2020

Short description

Adds the ability to set (and reload) the dnsdist ACL from a file. File is parsed in exactly the same way as in recursor, and also errors in the file leave the previous ACL untouched.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank a lot for this pull request! The code and documentation seems good!

@qvr qvr force-pushed the feature/dnsdist-acl-from-file branch from 376bdde to cd36cfb Compare December 8, 2020 08:55
@rgacogne rgacogne merged commit 8586e6c into PowerDNS:master Dec 9, 2020
@qvr qvr deleted the feature/dnsdist-acl-from-file branch December 9, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants