-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UUID: Use the non-cryptographic variant of the boost::uuid #9832
Conversation
Whoops, looks like I cleaned my code a bit too much after testing since it doesn't compile anymore, fixing that! |
Since Boost 1.67.0 the default UUID generator is cryptographically strong, which is neat but quite slower. Since we don't need that, just use the fastest version.
2f29e0d
to
0acc8b3
Compare
We have to make sure a non-seeded |
That's a very good point! From the documentation in the uuid class I did not expect we needed to seed it, but the documentation in the random class makes me think it can very well be. Now I wonder if we have been doing it wrong in the past.. |
The old boost implementations (which used MT) seem to seed it at construct time. |
The
|
Test on OpenBSD (boost 1.70) shows the MT is seeded. Original code:
New code:
I'll push the speedtest to this branch. |
Short description
Since Boost 1.67.0 the default UUID generator is cryptographically strong, which is neat but quite slower. Since we don't need that, just use the fastest version.
Checklist
I have: