dnsdist: Fix SNI on resumed sessions by acknowledging the name sent by the client #9921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y the client Otherwise `SSL_get_servername()` only returns true when the session has been freshly established, and will return `nullptr` when it is resumed.
Merged
7 tasks
omoerbeek
reviewed
Jan 7, 2021
| /* we need to set this callback to acknowledge the server name sent by the client, | ||
| otherwise it will not stored in the session and will not be accessible when the | ||
| session is resumed, causing SSL_get_servername to return nullptr */ | ||
| SSL_CTX_set_tlsext_servername_callback(ctx.get(), &libssl_server_name_callback); |
There was a problem hiding this comment.
extremely pedantic nit: redundant &
There was a problem hiding this comment.
I personally prefer it that way to make it more clear that we pass the address of the function, and not the result of a call to the function.
There was a problem hiding this comment.
To my eyes it's clear it isn't a call since no arguments are passed. But fair enough.
|
Regression tests added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Otherwise
SSL_get_servername()only returns true when the session has been freshly established, and will returnnullptrwhen it is resumed.Checklist
I have: