Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist-1.5.x: Fix SNI on resumed sessions by acknowledging the name sent by the client #9922

Merged
merged 5 commits into from Jan 11, 2021

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Jan 7, 2021

Short description

Otherwise SSL_get_servername() only returns true when the session has been freshly established, and will return nullptr when it is resumed.

(cherry picked from commit 767a9d3)

Backport of #9921 on rel/dnsdist-1.5.x.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

…y the client

Otherwise `SSL_get_servername()` only returns true when the session
has been freshly established, and will return `nullptr` when it is
resumed.

(cherry picked from commit 767a9d3)
@rgacogne rgacogne merged commit f631910 into PowerDNS:rel/dnsdist-1.5.x Jan 11, 2021
@rgacogne rgacogne deleted the ddist15-sni-resumption branch January 11, 2021 13:57
@rgacogne rgacogne mentioned this pull request Mar 10, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant