Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Appease clang++ 12 asan on MacOS #9925

Merged

Conversation

omoerbeek
Copy link
Member

MacOS clang++ 12 with asan does not like to access a vector of bytes
outside it's begin()..end(), even thouh we assured there is capacity.
So make sure the size is set before groping inside the vector.

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

MacOS clang++ 12 with asan does not like to access a vector of bytes
outside it's begin()..end(), even thouh we assured there is capacity.
So make sure the size is set before groping inside the vector.
@omoerbeek omoerbeek changed the title Appease clang++ 12 asan on MacOS dnsdist: Appease clang++ 12 asan on MacOS Jan 8, 2021
@rgacogne rgacogne added the defect label Jan 8, 2021
@rgacogne rgacogne added this to the dnsdist-1.6.0 milestone Jan 8, 2021
@omoerbeek omoerbeek merged commit ac6905a into PowerDNS:master Jan 8, 2021
@omoerbeek omoerbeek deleted the dnsdist-test-reserve-vs-resize branch January 8, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants