dnsdist: Start all TCP worker threads on startup #9957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of starting only as many TCP worker threads on startup as the number of TCP listeners, then starting more at runtime, start all TCP worker threads on startup. Change the default number of worker threads to at least 10, up to the number of TCP listener threads. Document that change and improve the tuning page a bit.
pieterlexis
reviewed
Jan 12, 2021
omoerbeek
reviewed
Jan 12, 2021
omoerbeek
reviewed
Jan 12, 2021
Co-authored-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Otherwise the distribution of queries to the backends is very hard to predict since every thread uses its own counter. We used to start only one worker thread at startup, and did not send enough queries to get additional workers fired up.
…dist-tcp-worker-threads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Instead of starting only as many TCP worker threads on startup as the number of TCP listeners, then starting more at runtime, start all TCP worker threads on startup.
Change the default number of worker threads to at least 10, up to the number of TCP listener threads.
Document that change and improve the tuning page a bit.
Checklist
I have: