dnsdist: Deprecate parameters to webserver(), add 'statsRequireAuthentication' parameter #9972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tication' parameter This PR deprecates the use of additional parameters with `webserver()`, as the syntax is confusing and could lead to believe that the parameters are per-instance while they actually are global. Also implements an additional 'statsRequireAuthentication' parameter to allow scraping the statistics without any kind of authentication, which is useful to Prometheus setups with dynamic service discovery.
pieterlexis
reviewed
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Short description
This PR deprecates the use of additional parameters with
webserver(), as the syntax is confusing and could lead to believe that the parameters are per-instance while they actually are global.Also implements an additional 'statsRequireAuthentication' parameter to allow scraping the statistics without any kind of authentication, which is useful to Prometheus setups with dynamic service discovery.
Closes #8710.
Closes #9311.
Checklist
I have: