Skip to content

dnsdist: Deprecate parameters to webserver(), add 'statsRequireAuthentication' parameter #9972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Jan 13, 2021

Short description

This PR deprecates the use of additional parameters with webserver(), as the syntax is confusing and could lead to believe that the parameters are per-instance while they actually are global.
Also implements an additional 'statsRequireAuthentication' parameter to allow scraping the statistics without any kind of authentication, which is useful to Prometheus setups with dynamic service discovery.

Closes #8710.
Closes #9311.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

…tication' parameter

This PR deprecates the use of additional parameters with `webserver()`,
as the syntax is confusing and could lead to believe that the parameters
are per-instance while they actually are global.
Also implements an additional 'statsRequireAuthentication' parameter
to allow scraping the statistics without any kind of authentication,
which is useful to Prometheus setups with dynamic service discovery.
@rgacogne rgacogne enabled auto-merge January 18, 2021 07:19
@rgacogne rgacogne disabled auto-merge January 19, 2021 10:00
@rgacogne rgacogne merged commit d7ea012 into PowerDNS:master Jan 19, 2021
@rgacogne rgacogne deleted the ddist-stats-no-auth branch January 19, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants