dnsdist: Limit the number of concurrent console and web connections #9997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
rgacogne
force-pushed
the
ddist-concurrent-conns
branch
from
ee4dbe6 to
6cf749d
Compare
|
Rebased to fix a conflict, added some unit tests in the process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Closes #4978.
This PR also cleans up a bit the console connection code, wrapping the socket to make sure it doesn't leak (existing code looked good but required some bookkeeping that the new one doesn't) and removing a couple unneeded allocations + copies.
Checklist
I have: