Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Limit the number of concurrent console and web connections #9997

merged 3 commits into from Jan 29, 2021


Copy link

@rgacogne rgacogne commented Jan 21, 2021

Short description

Closes #4978.

This PR also cleans up a bit the console connection code, wrapping the socket to make sure it doesn't leak (existing code looked good but required some bookkeeping that the new one doesn't) and removing a couple unneeded allocations + copies.


I have:

  • read the document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Member Author

Rebased to fix a conflict, added some unit tests in the process.

@rgacogne rgacogne merged commit 9904a34 into PowerDNS:master Jan 29, 2021
27 checks passed
@rgacogne rgacogne deleted the ddist-concurrent-conns branch January 29, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

dnsdist: Add options to limit the number of console and webserver threads
1 participant