diff --git a/.github/workflows/build-test-and-sonar.yml b/.github/workflows/build-test-and-sonar.yml index 3e323dda..759cf16f 100644 --- a/.github/workflows/build-test-and-sonar.yml +++ b/.github/workflows/build-test-and-sonar.yml @@ -96,7 +96,7 @@ jobs: - name: SonarCloud Scan if: ${{ (github.event_name == 'push') || (github.event.pull_request.head.repo.owner.login == 'PowerGridModel') }} - uses: SonarSource/sonarcloud-github-action@master + uses: SonarSource/sonarqube-scan-action@master env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} diff --git a/src/power_grid_model_io/functions/filters.py b/src/power_grid_model_io/functions/filters.py index 896abe70..09b142b6 100644 --- a/src/power_grid_model_io/functions/filters.py +++ b/src/power_grid_model_io/functions/filters.py @@ -31,7 +31,8 @@ def exclude_value(row: pd.Series, col: str, value: Union[float, str]) -> bool: if col not in row: raise ValueError(f"The column: '{col}' cannot be found for the filter") result = row[col] != value - if isinstance(result, pd.Series): + # Sonar cloud false positive (S2583): result can be a pd.Series of bool + if isinstance(result, pd.Series): # NOSONAR return result.item() return result