Skip to content

Conversation

@Jerry-Jinfeng-Guo
Copy link
Member

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo commented Nov 26, 2025

Closes #338

In this PR:

  • Logic to handle optional_extra
  • Documentation
  • Test

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo self-assigned this Nov 26, 2025
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the feature New feature or request label Nov 26, 2025
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo changed the title logic to handle optional_extra Logic to handle optional_extra in Vision Excel converter input Nov 26, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements logic to handle optional extra columns in the tabular converter, addressing issue #338. The feature allows specifying columns that should be included in extra_info if present but won't cause conversion failure if missing.

Key Changes:

  • Added allow_missing parameter throughout the column definition parsing chain to support optional columns
  • Implemented optional_extra wrapper in column definitions to mark columns as optional
  • Enhanced error handling to gracefully skip missing optional columns while preserving required column behavior

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/power_grid_model_io/converters/tabular_converter.py Core implementation of optional_extra logic with allow_missing parameter propagation and empty DataFrame handling for missing columns
tests/unit/converters/test_tabular_converter.py Comprehensive test coverage for optional_extra feature including edge cases and integration tests
docs/converters/vision_converter.md Documentation explaining optional_extra syntax, behavior, and use cases for Vision Excel exports

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Jerry-Jinfeng-Guo and others added 3 commits November 26, 2025 12:08
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 13 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Jerry-Jinfeng-Guo and others added 4 commits November 27, 2025 14:35
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Graceful Handling of Missing Extra Columns in Vision Excel Files

2 participants