From f89e6a04660ab4ed1ea1e355beb6d82801ed911b Mon Sep 17 00:00:00 2001
From: James Truher <jimtru@microsoft.com>
Date: Wed, 4 Nov 2020 14:18:34 -0800
Subject: [PATCH] Be sure to pass parameters along to follow on yml files

---
 assembly-module-compliance.yml | 14 +++++++-------
 script-module-compliance.yml   | 11 ++++++-----
 2 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/assembly-module-compliance.yml b/assembly-module-compliance.yml
index 4b7e020..6c13018 100644
--- a/assembly-module-compliance.yml
+++ b/assembly-module-compliance.yml
@@ -21,10 +21,10 @@ parameters:
 steps:
 - template: template-compliance/apiscan.yml
   parameters:
-    softwareFolder: ''
-    softwareName: ''
-    softwareVersion: ''
-    APIScanEnable: ''
+    softwareFolder: ${{ parameters.softwareFolder }}
+    softwareName: ${{ parameters.softwareName }}
+    softwareVersion: ${{ parameters.softwareVersion }}
+    APIScanEnable: ${{ parameters.APIScan }}
 
 - template: template-compliance/auto-applicability.yml
 
@@ -39,14 +39,14 @@ steps:
 
 - template: template-compliance/credscan.yml
   parameters:
-    suppressionsFile: ''
+    suppressionsFile: ${{ parameters.suppressionsFile }}
 
 - template: template-compliance/defender.yml
 
 - template: template-compliance/TermCheck.yml
   parameters:
-    optionsRulesDBPath: ''
-    optionsFTPath: ''
+    optionsRulesDBPath: ${{ parameters.optionsRulesDBPath }}
+    optionsFTPath: ${{ parameters.optionsFTPath }}
 
 - template: template-compliance/vulnerability-assessment.yml
 
diff --git a/script-module-compliance.yml b/script-module-compliance.yml
index 1dfedc7..8a389a3 100644
--- a/script-module-compliance.yml
+++ b/script-module-compliance.yml
@@ -20,14 +20,14 @@ steps:
 
 - template: template-compliance/credscan.yml
   parameters:
-    suppressionsFile: ''
+    suppressionsFile: ${{ parameters.suppressionsFile }}
 
 - template: template-compliance/defender.yml
 
 - template: template-compliance/TermCheck.yml
   parameters:
-    optionsRulesDBPath: ''
-    optionsFTPath: ''
+    optionsRulesDBPath: ${{ parameters.optionsRulesDBPath }}
+    optionsFTPath: ${{ parameters.optionsFTPath  }}
 
 - template: template-compliance/vulnerability-assessment.yml
 
@@ -35,11 +35,12 @@ steps:
 
 - template: template-compliance/tsa-upload.yml
   parameters:
-    codeBaseName: ''
+    codeBaseName: ${{ parameters.codeBaseName }}
 
 - template: template-compliance/sdtreport.yml
   parameters:
     APIScan: ${{ parameters.APIScan }}
-    BinSkim: true
+    # script modules should not distribute binaries
+    BinSkim: false
     CredScan: true
     TermCheck: true