Skip to content

fix off by one error with ellipsis #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2020
Merged

fix off by one error with ellipsis #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85fab56
fix off by one error with ellipsis
TylerLeonhardt Sep 29, 2020
4b8ff1f
rev version
TylerLeonhardt Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.PowerShell.ConsoleGuiTools/GridViewHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public static string GetPaddedString(List<string> strings, int offset, int[] lis
// If the string won't fit in the column, append an ellipsis.
if (strings[i].Length > listViewColumnWidths[i])
{
builder.Append(strings[i].Substring(0, listViewColumnWidths[i] - 4));
builder.Append(strings[i], 0, listViewColumnWidths[i] - 3);
builder.Append("...");
}
else
Expand Down
6 changes: 5 additions & 1 deletion src/Microsoft.PowerShell.ConsoleGuiTools/Microsoft.PowerShell.ConsoleGuiTools.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
RootModule = 'Microsoft.PowerShell.ConsoleGuiTools.dll'

# Version number of this module.
ModuleVersion = '0.6.0'
ModuleVersion = '0.6.1'

# Supported PSEditions
CompatiblePSEditions = @( 'Core' )
Expand Down Expand Up @@ -106,6 +106,10 @@ PrivateData = @{
# ReleaseNotes of this module
ReleaseNotes = '# Release Notes

## v0.6.1

Fix off-by-one error with ellipsis so columns should be better aligned.

## v0.6.0

Now supports `-Filter` parameter.
Expand Down