Tighter columns & less rows #115
Conversation
Co-Authored-By: Tyler James Leonhardt <tylerl0706@gmail.com>
TylerLeonhardt
left a comment
TylerLeonhardt
left a comment
There was a problem hiding this comment.
Did you need me to test this again to make sure the checkbox wasn't blank?
Build.ps1
Outdated
| @@ -1,3 +1,3 @@ | |||
| Invoke-Build Build | |||
There was a problem hiding this comment.
Honestly if you wanna have this just build ConsoleGuiTools for now that's probably fine since Graphical Tools is waiting on MAUI
There was a problem hiding this comment.
Thanks. Builds take toooo loooong.
There was a problem hiding this comment.
What should I change to make this so?
There was a problem hiding this comment.
@TylerLeonhardt I am struggling figuring out how to change the build scripts to build only CGT. Can you give me a hint por-favor?
There was a problem hiding this comment.
@TylerLeonhardt Nevermind - figured it out:
param(
[ValidateSet("Debug", "Release")]
[string]$Configuration = "Debug",
[string[]]$ModuleName = @(
#"Microsoft.PowerShell.GraphicalTools",
"Microsoft.PowerShell.ConsoleGuiTools" )
)
Although, to do this right, it would be nice to have the GraphicalTools.build.ps1 take a parameter [Gui|ConoleGui|Both] such that Build.ps1 could do this:
Invoke-Build Build ConsoleGui
But I'm not savvy enough on PS yet to put the logic into the param statement above.
There was a problem hiding this comment.
Nevermind again - I'm now savvy enough. ;-) see latest commit.
There was a problem hiding this comment.
And FWIW, my changes do not impact the CI/CD builds. Both modules are still being built there, which seems right minded.
|
oh I see "prepare" got it |
SteveL-MSFT
left a comment
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Just one question, otherwise looks good. If trying to make efficient use of screen real estate, should we replace ... with … (should be separate PR anyways)
|
didn't we try the |
|
Unfortunately … is one of those Unicode chars that spans two columns. Which is hard on consoles, and not supported in gui.cs yet.
|
3 participants
This PR improves usage of scarce screen real estate by
It also prepares for an upcoming change to Terminal.Gui that will change the clunky 3 character check/select UI (
[x]) to single char glyphs (√);