DscResources: Added submodule NetworkingDsc, and xDisk #382
Conversation
@PlagueHO Do you mind reviewing this one too when you have a chance? VS Code trimmed a lot of white spaces, so it's look bigger than it is. |
Sweet as @johlju . I'll get on to this and the other ones tomorrow! |
Everything looks good, but just a question about whether or not we should still include deprecated resources as submodules? Reviewed 10 of 10 files at r1. .gitmodules, line 196 at r1 (raw file):
Should this resource still be linked as a submodule if it is deprecated? Same goes for xTimezone. Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion. .gitmodules, line 196 at r1 (raw file): Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
I understand your point. This repo was linked to the Waffle board. I thought is since they is a part of DSC Resource Kit we keep the linked here too so they don't float around without an "owner". I personally rather see these deprecated repos removed entirely later on, and then we can remove and references to them. Comments from Reviewable |
- Added deprecated resource module xDisk for reference. - Renamed xNetworking to NetworkingDsc - Minor updates to integration tests template. - Switched examples in TestGuidelines because the previous resource tests had gotten too complex for an easy example.
@PlagueHO Do you have time to sign-off on this one unless you have another argument for us leaving out xDisk? 🙂 |
Doh! Sorry I missed this @johlju - I'll sign it off first thing tomorrow (only on my phone atm) |
Reviewed 1 of 1 files at r2. Comments from Reviewable |
tests had gotten too complex for an easy example.
This change is